Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace property 'reporterType' by 'reporter' in README file #1289

Merged
merged 2 commits into from
May 4, 2022
Merged

Replace property 'reporterType' by 'reporter' in README file #1289

merged 2 commits into from
May 4, 2022

Conversation

maugagneur
Copy link
Contributor

Description

Since 237cb2c (embedded in releases 1.0.3 and 1.1.0), the name of the property in README.md file was not aligned with the definition of the property in DiktatExtension.kt file

What's done

  • Replace property 'reporterType' by 'reporter' in README file

maugagneur and others added 2 commits May 4, 2022 09:49
@maugagneur
Replace property 'reporterType' by 'reporter' in README file
539d024 
The name of the property in README.md file was not aligned with the definition of the property in DiktatExtension.kt file
@orchestr7
Merge branch 'master' into documentation/update_property_name_in_readme
deec7b4
@orchestr7 orchestr7 closed this May 4, 2022
@orchestr7 orchestr7 reopened this May 4, 2022
@orchestr7
Copy link
Member

Hi, thank you so much for this PR this is very valuable! Unfortunately we always miss such issues in readme and don’t have proper checks for it

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #1289 (deec7b4) into master (5120633) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1289   +/-   ##
=========================================
  Coverage     82.36%   82.36%           
  Complexity     2550     2550           
=========================================
  Files           105      105           
  Lines          7202     7202           
  Branches       2020     2020           
=========================================
  Hits           5932     5932           
  Misses          351      351           
  Partials        919      919
Flag Coverage Δ
unittests 82.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5120633...deec7b4. Read the comment docs.

@maugagneur
Copy link
Contributor Author

Hi, thank you so much for this PR this is very valuable! Unfortunately we always miss such issues in readme and don’t have proper checks for it

It not a big deal. I just saw this when trying to update diktat from version 1.0.2

@orchestr7 orchestr7 merged commit ca8cd62 into saveourtool:master May 4, 2022
@maugagneur maugagneur deleted the documentation/update_property_name_in_readme branch May 4, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orchestr7 orchestr7 orchestr7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maugagneur @orchestr7